Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding exception handling to web app to avoid hard crashing #57

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trwalke
Copy link
Contributor

@trwalke trwalke commented Mar 22, 2024

Purpose

Adding exception handling to web app to avoid hard crashing

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@jmprieur
Copy link
Collaborator

@trwalke

This is not about adding the index.cs and index.html in the sample
It's about adding a code similar to that in the controller here

that is:

  [AuthorizeForScopes(ScopeKeySection = "DownstreamApi:Scopes:Read")]
    public async Task<ActionResult> Index()
    {
+      try 
 +     {
        var toDos = await _downstreamApi.GetForUserAsync<IEnumerable<ToDo>>(
            ServiceName,
            options => options.RelativePath = "api/todolist");

        return View(toDos);
+      }
+     catch (Exception ex)
+     {
+       return NoContent(); // or another method of ControllerBase.
+      }
    }

What was your experience when you had to use a private browsing session? what was the error?

@jmprieur
Copy link
Collaborator

@trwalke will you move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants