Add support for hyprland's new IPC event since v0.37.0 and change 'switch case' to map #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will slightly improve performace and make it convenient for the future changes.
If Hyprland's version is greater than v0.37.0 (if the commit date is after 2024-3-16), then `workspacev2`, `createworkspacev2`, `destoryworkspacev2`, `movewindowv2`, `moveworkspacev2` is listend instead of their non-v2 versions. Note that under `createworkspacev2` and `destoryworkspacev2`, `workspace-added` and `workspace-removed` signal return workspace's id, not name.
|
the performance difference between a map and a switch statement should be insignificant, while the switch statement is a lot more readable I think its fine to just update the events to v2 and the signals type to |
A7R7
changed the title
|
I've dropped backward compatibility support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr changes the 'switch case' code structure to a Map of events to callbacks, which will slightly improve performace and make it convenient for the following changes.
On top of that, it adds support for hyprland's new IPC event since v0.37.0.
If Hyprland's version is greater than v0.37.0 (if the commit date is after 2024-3-16), then
workspacev2,createworkspacev2,destoryworkspacev2,movewindowv2,moveworkspacev2is listend instead of their non-v2 versions.
Note that under
createworkspacev2anddestoryworkspacev2,workspace-addedandworkspace-removedsignal return workspace's id, not name.