Add the WooPay Direct Checkout flow to the blocks mini cart widget #8795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +317 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ricardo
commented
May 8, 2024
ricardo
commented
May 8, 2024
lovo-h
requested changes
May 10, 2024
There was a problem hiding this comment.
The code changes look good and have test well.
There were just a few, minor details I wanted to confirm before merging.
Testing Instructions
- ✅ Test 1: Ensure the direct checkout scripts are enqueued in the right pages.
- ✅ Test 2: Ensure the direct checkout flow works in the mini cart.
- ✅ Test 3: Ensure the direct checkout flow works from classic and blocks checkout.
- ✅
npm run test:js.
| ! WooPayDirectCheckout.isWooPayDirectCheckoutEnabled() || | ||
| shouldSkipWooPay() | ||
| ) { | ||
| if ( shouldSkipWooPay() ) { |
There was a problem hiding this comment.
This is not related to this PR but am I correct in my thinking that we may want to add similar logic (early exit when shouldSkipWooPay()) to the following functions, below:
addItemCallback().debounceSetItemQtyCallback().removeItemCallback().
Otherwise, we will be prefetching encrypted session data that will not be used.
There was a problem hiding this comment.
I agree.
Instead of checking for shouldSkipWooPay, I added the hooks in the load window event listener and after isWooPayThirdPartyCookiesEnabled() in 5ce2d84. LMK what you think.
@lovo-h – I tested this by adding a console.log to each callback and going to the blocks cart and adding, removing and setting the quantity of an item, however I wasn't able to hit the action hook when adding a new item from the suggestions list after the cart is emptied, am I testing this wrong? What's one way to hit the experimental__woocommerce_blocks-cart-add-item?
There was a problem hiding this comment.
Instead of checking for
shouldSkipWooPay, I added the hooks in theloadwindow event listener and afterisWooPayThirdPartyCookiesEnabled()in 5ce2d84. LMK what you think.
I think this approach looks cleaner. Good call.
I wasn't able to hit the action hook when adding a new item from the suggestions list after the cart is emptied, am I testing this wrong? What's one way to hit the
experimental__woocommerce_blocks-cart-add-item?
Good catch.
I also wasn't able to trigger this callback either. It appears like it was removed in WooCommerce:
If I recall correctly, this hook was added when wcBlocks was an independent plugin from WooCommerce. In wcBlocks, it looks like the experimental__woocommerce_blocks-cart-add-item hook still exists.
One solution would be to replace the experimental__woocommerce_blocks-cart-add-item hook with wc-blocks_added_to_cart:
document.body.addEventListener(
'wc-blocks_added_to_cart',
addItemCallback
);However, this is an unrelated issue to this PR. So, we can create a separate GH issue.
There was a problem hiding this comment.
Created an issue. Feel free to look into this if you have the availability.
…after "WooPayDirectCheckout.init()"
lovo-h
approved these changes
May 15, 2024
There was a problem hiding this comment.
Code changes look good and test well 👍
Testing Instructions
- ✅ Test 1: Ensure the direct checkout scripts are enqueued in the right pages.
- ✅ Test 2: Ensure the direct checkout flow works in the mini cart.
- ✅ Test 3: Ensure the direct checkout flow works from classic and blocks checkout.
- ✅
npm run test:js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2647-gh-Automattic/woopay
Changes proposed in this Pull Request
woocommerce_blocks_cart_enqueue_dataaction, which is used by the blocks mini cart and cart as widgets (src).Note: In this PR we are not adding support for the legacy mini cart
woocommerce_mini_cart()yet.Testing instructions
Setup
_wcpay_feature_woopay_direct_checkoutis set to1.npm run build:client.Test 1: Ensure the direct checkout scripts are enqueued in the right pages
WCPAY_WOOPAY_DIRECT_CHECKOUTscript is enqueued in the page source.WCPAY_WOOPAY_DIRECT_CHECKOUTscript is NOT enqueued in the page source.Test 2: Ensure the direct checkout flow works in the mini cart
Test 3: Ensure the direct checkout flow works from classic and blocks checkout
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge