New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add survey modal on WooPayments deactivation #8757
base: develop
Are you sure you want to change the base?
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +20 kB (+2%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
@elizaan36, what do you think about developing a new CrowdSignal style theme? This would help reduce the spacing between paragraphs and headings, allowing us to fit the survey into the modal without requiring a scrollbar. |
hey @mordeth How do you create a new theme in Crowdsignal? |
If you scroll down on the theme selection screen, you'll find a button to create a new custom theme. If you prefer, I can create a new theme style with reduced spacings, and you can review it later. WDYT? |
Thanks @mordeth, I think it would help a lot if you were able to give that a try! I mocked it up quickly to see how we could adjust the spacing. Here I've reduced spacing between the selections, and the Additional comments. Also it would balance the form to have equal margins top and bottom (it needed some space above the WooPayments logo). Hopefully this can help remove the scrollbar. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, worked well with a fix we discussed in Slack p1716195847191189/1716192002.072229-slack-C03KTTK2YMA! Left a couple of code suggestions, the main is to add wp-components
as a dependency to make it work. Pre-approving 🟢
Leaving the design approval to @elizaan36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since I think the theme changes can be applied outside the scope of this PR.
Fixes #1527
Changes proposed in this Pull Request
This PR aims to enhance user experience by implementing a feedback survey modal upon deactivation of the WooPayments plugin. Providing users with the opportunity to share their feedback upon deactivation will help us better understand their needs and preferences, ultimately leading to a more refined product.
Testing instructions
Plugins
.WooPayments
plugin.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge