Increase font on WooPay button #8715
Open
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +6 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
|
Shortcode Cart Default Blocks Cart Default |
|
Shortcode Checkout Default - Before After Shortcode Checkout Med Shortcode Checkout Large Blocks Checkout Default - Before After Blocks Checkout Med Blocks Checkout Large |
|
Product Page - Before After Product Page Med Product Page Large |
LCmry
force-pushed
the
update/increase-woopay-button-font
branch
from
b0a41f6
to
ab17872
Compare
|
@pierorocca and @nikkivias for reviewing the look please. |
|
I'm on mobile and afk. At a quick glance the size looks good but the font weight seems heavier than the dev guidelines? Could you confirm the logic is getting applied to the light and outline theme options? |
|
Thanks for taking a look @pierorocca .
I only changed the font size. Where are the guidelines for weight? I can check into them. Can confirm it is the same for light and outline options. |
|
@LCmry what I'm seeing in the Figma is SF Pro Text Medium. Here's the Figma Large 54 px button for comparison. What web font is being used and current weight?
|
|
@pierorocca the current font is 'SF Pro Text' and current weight is 500. |
|
Thanks @LCmry. 500 does correspond to Medium. It looks like Figma rendering can be different than what's actually rendered by different devices and browsers. https://forum.figma.com/t/font-sfprotext-medium-displays-different-between-figma-vs-ios/9513 @nikkivias any thoughts here? Keep weight at 500 or drop down to 400 to try and match Figma? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8136
Changes proposed in this Pull Request
Increase the font on the WooPay button so it is more in line with other PRB buttons.
Testing instructions
Borrowed from issue
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge