Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display 0 fee value as number instead of N/A in transaction list #8640

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

SpaceSurfer1
Copy link

@SpaceSurfer1 SpaceSurfer1 commented Apr 14, 2024

In transaction listing, when fee value is 0, number will be displayed instead of N/A.

Fixes #8286

Testing instructions

  • Using a US merchant, assign wcpay-discount-100-off and refresh the client cache
  • Perform a test purchase (any payment method)
  • Check the transactions listing page and compare it to transaction details page

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@SpaceSurfer1 SpaceSurfer1 force-pushed the update/display-zero-fee-value-instead-of-N/A-in-transaction-list branch 3 times, most recently from 75f892e to b2786db Compare April 17, 2024 15:20
@anu-rock anu-rock requested a review from kalessil April 18, 2024 08:45
In transaction listing, when fee value is 0, number will be displayed instead of N/A.
@SpaceSurfer1 SpaceSurfer1 force-pushed the update/display-zero-fee-value-instead-of-N/A-in-transaction-list branch from b2786db to 4c57107 Compare April 18, 2024 13:54
@SpaceSurfer1
Copy link
Author

Hi, @kalessil , @anu-rock , can you kindly review this PR? Thanks. 👍

Copy link
Contributor

@kalessil kalessil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SpaceSurfer1!

Overall looks good, a couple of things remaining:

EDIT: the tests I was waiting for are green, so we only need a changelog entry here.

@kalessil kalessil requested a review from a team May 7, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using a "N/A" as fee value on the Transactions listing
2 participants