Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiCurrency Check - if a value is set #8305

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

anastas10s-afk
Copy link

Changes proposed in this Pull Request

Belated follow-up to 7193852-zen.
Created this PR for pinging the dev team, in case such a code addition would be prudent.

  • Cannot reproduce the error, when testing with a test site of mine
  • Logs are clean; nothing reported there
  • Does not break my test site, either, with or without multi-currency option enabled
  • Tested with versions 6.6.2, and 7.2.0

https://snipboard.io/bZeWm6.jpg


  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant