Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook: Add theme #7687

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Cookbook: Add theme #7687

wants to merge 6 commits into from

Conversation

alaczek
Copy link
Contributor

@alaczek alaczek commented Mar 19, 2024

Add Cookbook theme. See more: pNEWy-hjH-p2

image

cc @henriqueiamarino

Add Cookbook theme.
@alaczek
Copy link
Contributor Author

alaczek commented Mar 19, 2024

I activated the theme and I noticed a few things I wanted to double check with you @henriqueiamarino:

  • in home.html template the blog post query is not inheriting query from the template, which results in an empty space, and need for extra config. Shall I change this to inhert query from template?
  • single page template doesn't include the page template. What do you think about adding one?
  • archive template is missing page navigation, so it's not possible to access all posts.
  • the search template looks off - the header colors are different, and the layout of search results is not a grid - would it make sense to reuse the archive templates here to make it more consistent?
image

Let me know how you would like to address those and I can help!

@henriqueiamarino
Copy link
Collaborator

henriqueiamarino commented Mar 19, 2024

I just replied to it on Slack.
I am reviewing all the themes I designed in my first year using the Editor, as I learned many best practices and will apply them. The same goes for style variations; my idea is to make them available in all my themes.

As soon as I finish the Cookbook update, I'll have it linked to this post; thanks.

@henriqueiamarino
Copy link
Collaborator

The theme was thoroughly reviewed, and the following final is the final version; thanks, @alaczek.
cookbook-update.zip

@alaczek
Copy link
Contributor Author

alaczek commented Apr 24, 2024

This is looking good to me (I pushed a tiny fix). I have two questions (not blockers):

  • could this text color be the same as header color? It's clashing a bit with the background in the Gecko's Dream variation
image
  • I was wondering why the header.php pattern is hidden?
<?php
/**
 * Title: header
 * Slug: cookbook/header
 * Categories: hidden
 * Inserter: no
 */
?>

@henriqueiamarino
Copy link
Collaborator

@alaczek I have no idea why the Header is hidden. I exported the theme using Create Block Theme, as I do regularly.

You're right about the black/green contrast on Gecko's style; it's not WCAG AAA as it should be. I will fix it as soon as I can export a theme again. Changes to the plugin are blocking me right now. Hopefully, I'll have the chance to fix it on Friday. Thank you.

Screenshot 2024-04-24 at 12 16 52

Update the text color in the header;
Wrap text in translation function.
Wrap text in translation function.
Copy link

Preview changes

I've detected changes to the following themes in this PR: Cookbook.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@alaczek
Copy link
Contributor Author

alaczek commented Apr 26, 2024

I fixed the text color for you @henriqueiamarino and wrapped some texts in a translation function. I think we're good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants