New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookbook: Add theme #7687
base: trunk
Are you sure you want to change the base?
Cookbook: Add theme #7687
Conversation
Add Cookbook theme.
I activated the theme and I noticed a few things I wanted to double check with you @henriqueiamarino:
Let me know how you would like to address those and I can help! |
I just replied to it on Slack. As soon as I finish the Cookbook update, I'll have it linked to this post; thanks. |
The theme was thoroughly reviewed, and the following final is the final version; thanks, @alaczek. |
Remove an extra character.
@alaczek I have no idea why the Header is hidden. I exported the theme using Create Block Theme, as I do regularly. You're right about the black/green contrast on Gecko's style; it's not WCAG AAA as it should be. I will fix it as soon as I can export a theme again. Changes to the plugin are blocking me right now. Hopefully, I'll have the chance to fix it on Friday. Thank you. |
Update the text color in the header; Wrap text in translation function.
Wrap text in translation function.
Preview changesI've detected changes to the following themes in this PR: Cookbook. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
I fixed the text color for you @henriqueiamarino and wrapped some texts in a translation function. I think we're good to go! |
Add Cookbook theme. See more: pNEWy-hjH-p2
cc @henriqueiamarino