Fix E2E tests #76
Draft
Fix E2E tests #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
commented
May 2, 2024
src/components/onboarding.tsx
Outdated
| <div | ||
| className="flex flex-row flex-grow" | ||
| data-testid="onboarding" | ||
| > |
There was a problem hiding this comment.
We could actually remote this, given the current code doesn't use it because I couldn't get it to work.
mokagio
commented
May 2, 2024
| const frontendUrl = await siteContent.frontendButton.textContent(); | ||
| expect( frontendUrl ).toBeTruthy(); | ||
| expect( frontendUrl ).not.toBeNull(); |
There was a problem hiding this comment.
It might be better to make this "to not be empty"
mokagio
commented
May 2, 2024
mokagio
commented
May 2, 2024
e2e/page-objects/onboarding.ts
Outdated
Comment on lines
18
to
38
| get siteNameInput() { | ||
| return this.locator.getByLabel( 'Site name' ); | ||
| } | ||
|
|
||
| get sitePathInput() { | ||
| return this.locator.getByLabel( 'Local path' ); | ||
| } | ||
|
|
||
| get continueButton() { | ||
| return this.locator.getByRole('button', { name: 'Continue' }); | ||
| } | ||
|
|
||
| private get localPathButton() { | ||
| return this.locator.getByTestId( 'select-path-button' ); | ||
| } | ||
|
|
||
| // This usually opens an OS folder dialog, except we can't interact with it in playwrite. | ||
| // In tests the dialog returns the value of the E2E_OPEN_FOLDER_DIALOG environment variable. | ||
| async clickLocalPathButtonAndSelectFromEnv() { | ||
| await this.localPathButton.click(); | ||
| } |
There was a problem hiding this comment.
Part of this logic is duplicated from add-site-modal.ts. I shall extract it in a site-form.ts object, but maybe in a followup PR. Very keen to get E2E back to stable in CI.
mokagio
force-pushed
the
mokagio/e2e-fix-attempt
branch
from
47a027b
to
034f575
Compare
mokagio
changed the base branch from
mokagio/macos-e2e-tests
to
mokagio/e2e-fix-locally
mokagio
force-pushed
the
mokagio/e2e-fix-attempt
branch
from
034f575
to
1a39796
Compare
Currently failing, see #37
mokagio
force-pushed
the
mokagio/e2e-fix-attempt
branch
from
1a39796
to
2e6fd2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Rebased on top of #99. The diff is noisy because it includes the changes from #17, too.
Works on my machine™
Let's see what CI does...
Related to #
Proposed Changes
Testing Instructions
Pre-merge Checklist