fix: Multipart encoding handles missing files #115
Conversation
| @@ -17,7 +17,7 @@ export async function encodeAsMultipart( req: Express.Request ) { | |||
| parts.push( textEncoder.encode(value) ); | |||
| parts.push( `\r\n` ); | |||
| } | |||
| const files = req.files; | |||
| const files = req.files || {}; | |||
There was a problem hiding this comment.
A similar fallback value existed in previous iteration of the logic that inspired this function. Here, we reinstate the fallback value to handle multipart/form-data submissions that do not contain files.
Tangentially related, I responded to a suggestion that we might remove this logic altogether, but I do not think that is possible without implementing different logic in its place.
|
The fix proposed in this PR also appears to resolve #110: Unable to load a font file, which is also affected by the @dcalhoun I've linked #110 as a Development issue to be resolved by this PR. Happy to help with further testing when ready. |
Forms can submit using `multipart/form-data` without an `type="file"` input. When that occurs, the request's file attribute is `null`, so we must provide a fallback value to avoid errors.
dcalhoun
force-pushed
the
fix/multipart-encoding-handles-missing-files
branch
from
4101275
to
47f95b8
Compare
|
Superseded by #122. |
Relates to https://github.com/Automattic/dotcom-forge/issues/6922.
Fixes #110.
Proposed Changes
Forms can submit using
multipart/form-datawithout atype="file"input. When that occurs, the request's file attribute is
null, so wemust provide a fallback value to avoid errors.
Testing Instructions
WooCommerce Settings Persist Successfully
Note
Database errors outlined in https://github.com/Automattic/dotcom-forge/issues/6922 remain and will be addressed separately.
Fonts Successfully Upload
Follow the steps outlined in #110.
Pre-merge Checklist