Add Windows Release Builds #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
force-pushed
the
add/windows-release-builds
branch
2 times, most recently
from
bc9cce5
to
41f2956
Compare
jkmassel
force-pushed
the
add/windows-release-builds
branch
from
41f2956
to
36c9c16
Compare
jkmassel
added
[Platform] Windows
mokagio
approved these changes
May 13, 2024
Comment on lines
+10
to
+12
| npm run make | ||
| If ($LastExitCode -ne 0) { Exit $LastExitCode } | ||
|
|
There was a problem hiding this comment.
Suggested change
| npm run make | |
| If ($LastExitCode -ne 0) { Exit $LastExitCode } | |
| npm run make | |
| If ($LastExitCode -ne 0) { Exit $LastExitCode } |
Comment on lines
+10
to
+12
| npm run make | ||
| If ($LastExitCode -ne 0) { Exit $LastExitCode } | ||
|
|
There was a problem hiding this comment.
Suggested change
| npm run make | |
| If ($LastExitCode -ne 0) { Exit $LastExitCode } | |
| npm run make | |
| If ($LastExitCode -ne 0) { Exit $LastExitCode } |
| install_gems | ||
| bundle exec fastlane distribute_release_build | ||
| agents: | ||
| queue: "mac" # |
There was a problem hiding this comment.
Suggested change
| queue: "mac" # | |
| queue: "mac" |
Comment on lines
138
to
141
| const releaseVersionZipFilename_mac = `https://cdn.a8c-ci.services/studio/studio-darwin-v${ version }.app.zip`; | ||
| const releaseVersionZipFilename_x64 = `https://cdn.a8c-ci.services/studio/studio-darwin-x64-v${ version }.app.zip`; | ||
| const releaseVersionZipFilename_arm64 = `https://cdn.a8c-ci.services/studio/studio-darwin-arm64-v${ version }.app.zip`; | ||
| const releaseVersionZipFilename_win32 = `https://cdn.a8c-ci.services/studio/studio-win32-v${ version }.exe`; |
There was a problem hiding this comment.
Interesting mix of camel- and snake- casing.
Did you use it to better visually distinguish the platform?
Did you consider:
Suggested change
| const releaseVersionZipFilename_mac = `https://cdn.a8c-ci.services/studio/studio-darwin-v${ version }.app.zip`; | |
| const releaseVersionZipFilename_x64 = `https://cdn.a8c-ci.services/studio/studio-darwin-x64-v${ version }.app.zip`; | |
| const releaseVersionZipFilename_arm64 = `https://cdn.a8c-ci.services/studio/studio-darwin-arm64-v${ version }.app.zip`; | |
| const releaseVersionZipFilename_win32 = `https://cdn.a8c-ci.services/studio/studio-win32-v${ version }.exe`; | |
| const releaseVersionZipFilenameMac = `https://cdn.a8c-ci.services/studio/studio-darwin-v${ version }.app.zip`; | |
| const releaseVersionZipFilenameX64 = `https://cdn.a8c-ci.services/studio/studio-darwin-x64-v${ version }.app.zip`; | |
| const releaseVersionZipFilenameArm64 = `https://cdn.a8c-ci.services/studio/studio-darwin-arm64-v${ version }.app.zip`; | |
| const releaseVersionZipFilenameWin32 = `https://cdn.a8c-ci.services/studio/studio-win32-v${ version }.exe`; |
There was a problem hiding this comment.
Addressed in ed8c467
wojtekn
approved these changes
May 13, 2024
* Extract logic to distribute builds in Fastlane * DRY builds folder definition in Fastfile * Remove leftover debug `puts` * DRY S3 bucket name * Fix a comment's wording * DRY further * DRY even more * DRY commit, build, etc in Fastfile
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Creates signed Windows builds each time a new tag is created.
Testing Instructions
See https://a8c.slack.com/archives/C06DRMD6VPZ/p1715362399654439, note that each build is downloadable (and signed)