Fixes notification width on Students page #5278
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #5278 +/- ##
============================================
+ Coverage 40.70% 40.75% +0.05%
- Complexity 8604 8616 +12
============================================
Files 284 284
Lines 29012 29042 +30
============================================
+ Hits 11809 11837 +28
- Misses 17203 17205 +2
Continue to review full report at Codecov.
|
| flex-flow: column wrap; | ||
| align-items: flex-start; | ||
| gap: 20px; | ||
| display: grid; |
There was a problem hiding this comment.
My suggestion here would be to keep the previous code, because I think it would be better to move the notifications outside of the navigation. That way we won't have to account for them being there. See the next comments for more info.
There was a problem hiding this comment.
Forgot to mention that the grid view changes how the navigation looks on the other screen (some of the spacing is missing), but we won't have to worry about that if we decide to move the notifications outside.
| @@ -123,7 +122,7 @@ public function add_custom_navigation() { | |||
| if ( ! $screen ) { | |||
| return; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think the empty space here makes the linter angry. 😄 Could you remove it?
| <div id="sensei-custom-navigation" class="sensei-custom-navigation"> | ||
| <div class="sensei-custom-navigation__heading-with-info"> | ||
| <div class="sensei-custom-navigation__title"> | ||
| <h1><?php esc_html_e( 'Students', 'sensei-lms' ); ?></h1> | ||
| </div> | ||
| <div class="sensei-custom-navigation__separator"></div> | ||
| <a class="sensei-custom-navigation__info" target="_blank" href="https://senseilms.com/documentation/student-management?utm_source=plugin_sensei&utm_medium=docs&utm_campaign=student-management"> | ||
| <?php echo esc_html__( 'Guide To Student Management', 'sensei-lms' ); ?> | ||
| </a> | ||
| </div> | ||
| <div class="sensei-custom-navigation__separator"></div> | ||
| <a class="sensei-custom-navigation__info" target="_blank" href="https://senseilms.com/documentation/student-management?utm_source=plugin_sensei&utm_medium=docs&utm_campaign=student-management"> | ||
| <?php echo esc_html__( 'Guide To Student Management', 'sensei-lms' ); ?> | ||
| </a> | ||
| <hr class="wp-header-end"> |
There was a problem hiding this comment.
What do you think of moving the .wp-header-end element away from the navigation (reverting this change) and directly to the students inner page? My idea is to move it right after where the navigation would end up after it's moved by the JS code. I think in this case the element could be moved in these two files:
- html-admin-page-students-main.php (inside the
.wrapelement, before the action) - html-admin-page-students-course.php (before the
#poststuffelement)
Let me know if you have other ideas!
Fixes #5094
Changes proposed in this Pull Request
wp-header-endto position notification correct