Added login notice to single lesson & single quiz pages.

[hansschuijff]

Fixes #3150

Changes proposed in this Pull Request

• Add login notice to single lesson & single quiz page, when user is not logged and login is required to get access.
• Also moved the add_action for "sensei_single_course_content_inside_before" up in templates.php, since it belongs to the single course hooks and was inserted between the single lesson hooks.

[hansschuijff]

@donnapep I took a swing at issue #3150 and added a login notice to both the single lesson and the single quiz pages.

I updated the @hooked comments in 2 templates, added some callbacks that probably should have been mentioned there already (or not if you want to stop that practice all together), but didn't know if you want to change versions, since only the comments changed.

I deleted one statement in the existing code that was there twice and was redundant.

I didn't add filters on the new notices, but if you want them they are added easy enough.

Let me know what you think, when you get around to it. I'll leave this one for now.

[donnapep]

Thanks for this.

When a user is not logged in, rather than showing them two notices like this:

It would be preferable to display a single notice:

Then, once logged in and if they still haven't started the course, they would only see the original "Please sign up..." message. Ditto for the quiz.

[hansschuijff]

Hi @donnapep

I'll take a crack at it and will update the PR.

In the code there is already a notice for the quiz page with the text "You must be logged in to take this quiz". There I can just switch the if-else to first test for user logged in and it will probably work like you propose. Do you want to make the notice text the same as your proposal for lesson? So change the text to "Please log in to take this quiz"?

I also saw that the same logic should probably apply to the module page. There the enrol first notice is issued, but the situation is basically the same. And when a user should be logged in, there should be a notice saying that.

Hans

[donnapep]

Do you want to make the notice text the same as your proposal for lesson? So change the text to "Please log in to take this quiz"?

Sounds good. Consistency for the win. 🙂 I think there might even be a period missing on the existing quiz notice.

I also saw that the same logic should probably apply to the module page. There the enrol first notice is issued, but the situation is basically the same. And when a user should be logged in, there should be a notice saying that.

All makes sense to me. Thanks!

[hansschuijff]

Hi @donnapep

I think this is it. I made a uniform login notice for lessons, quizes and modules and it seems to work fine right now. There seems to be a conflict that prevents the merge, but that is probably something you need to look at, since I have no write access. The templates I only addes some comments to, so that can be removed and the scss I added modules to the notice-styles, since before they wheren't shown in the same styling as the notices on other sensei pages.
Let me know if there is anything else...
For now, I'm done with it.

[hansschuijff]

@donnapep
The @SInCE in the docblocks I will update when you tell me what version you want there. For now they are set on 3.2.0, because I started this pr when the current version was still 3.1.1.

I think frontend->messages may be redundant after this pr, but that's for you to decide. I only found a save quiz message that was added that way and think it might be a legacy property.

The pr uses Sensei()->notices->add_notice() instead of echo (what was used in quiz). I thought that would probably be the prefered way, since most code seems to use it at this moment.

[donnapep]

Now that we are starting to move away from templates and towards blocks, I've added thoughts on a block-based solution.