Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categories: Tracks events #1737

Merged
merged 2 commits into from May 14, 2024
Merged

Categories: Tracks events #1737

merged 2 commits into from May 14, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented May 9, 2024 •
edited

Adds new events to track Categories redesign behavior.

See https://github.com/Automattic/pocket-casts-webplayer/pull/2664 for more info on these changes.

To test

  • Navigate to a category
  • Tap the "+" button to subscribe to a sponsored podcast
馃數 Tracked: discover_list_podcast_subscribed ["podcast_uuid": "5b8d9890-80e6-013b-f2c3-0acc26574db2", "list_id": "e2d26ae1-1793-4465-94a5-c81ca7c8c39c"]
馃數 Tracked: discover_ad_category_subscribed ["category_id": 19, "podcast_uuid": "5b8d9890-80e6-013b-f2c3-0acc26574db2", "promotion_uuid": "e2d26ae1-1793-4465-94a5-c81ca7c8c39c"]
馃數 Tracked: podcast_subscribed ["uuid": "5b8d9890-80e6-013b-f2c3-0acc26574db2", "source": "discover"]
  • Tap the X pill to close back out to the main Discover page
  • Tap "All Categories"
  • Verify the following event is logged:
馃數 Tracked: discover_categories_picker_shown ["region": "global"]
  • Close the picker by tapping outside of it or selecting a category
馃數 Tracked: discover_categories_picker_closed ["region": "global"]

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added this to the 7.64 milestone May 9, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented May 9, 2024 •
edited

2 Warnings
鈿狅笍 View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
鈿狅笍 This PR is assigned to the milestone 7.64. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 馃毇 Danger

@bjtitus bjtitus marked this pull request as ready for review May 10, 2024 02:32
@bjtitus bjtitus requested a review from a team as a code owner May 10, 2024 02:32
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team May 10, 2024 02:32
SergioEstevao
SergioEstevao approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and all events are being logged correctly. :shipit:

@bjtitus bjtitus merged commit 24ccc44 into trunk May 14, 2024
12 checks passed
@bjtitus bjtitus deleted the bjtitus/categories/tracks-events branch May 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
Categories Redesign
Projects
None yet
Milestone
7.64
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjtitus @dangermattic @SergioEstevao