Re-add: Sleep Timer Improvements: fade out 5s before pausing playback #1736

leandroalonso · 2024-05-09T20:53:05Z

Same as #1629

Checklist

I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
I have considered adding unit tests for my changes.
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

dangermattic · 2024-05-09T20:53:29Z

	1 Warning
⚠️	This PR is assigned to the milestone 7.64. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

leandroalonso added 8 commits May 9, 2024 17:47

Add a new method to the playback protocol

6849bc3

Implement set volume on DefaultPlayer

a430582

Add audio mixer node to Effects Player to support changing volume

8892e41

Connect the audio mixer node

d5adf84

Ensure volume is 1 when playing

b2819b2

Add a manager to perform fade out on a given PlaybackProtocol

c7d7c9b

Add a method to perform a fade out

3a592c2

Fade out when sleep timer has 5s remaining

05c4f86

leandroalonso added the Sleep Timer label May 9, 2024

leandroalonso added this to the 7.64 milestone May 9, 2024

leandroalonso requested a review from a team as a code owner May 9, 2024 20:53

leandroalonso requested review from bjtitus and removed request for a team May 9, 2024 20:53

leandroalonso changed the base branch from trunk to readd/sleep-timer/shake-device-restart-timer May 9, 2024 20:53

Base automatically changed from readd/sleep-timer/shake-device-restart-timer to trunk May 10, 2024 18:44

bjtitus approved these changes May 10, 2024

View reviewed changes

leandroalonso merged commit 3548315 into trunk May 13, 2024
6 of 9 checks passed

leandroalonso deleted the readd/sleep-timer/fade-out-when-finishing branch May 13, 2024 14:30