Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll indicator insets to adjust for mini-player #1674

Merged
merged 21 commits into from May 20, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Apr 30, 2024

Fixes #1072

This PR updates the code on multiple view controllers to adjust correctly the insets for the content and scroll indicators depending of the visibility of the mini-player.

With Mini-Player Without Mini-Player
Simulator Screenshot - iPhone 15 Pro - 2024-05-17 at 10 47 47 Simulator Screenshot - iPhone 15 Pro - 2024-05-17 at 10 47 30

To test

  • Start the app
  • On each of the main tabs check the scrolling limits with and without the mini-player visible and see if the content and scrollbar indicators are correct and adjust to the mini-player visibility
    • Podcasts check on the root screen and inside folders
    • Discovery: check on the root screen, and navigate inside the sections
    • Filters: check on the root screen and inside specific filters
    • Profile: check on the root screen and the multiple settings and account screens

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the Bug Something isn't working label Apr 30, 2024
@SergioEstevao SergioEstevao added this to the 7.64 milestone Apr 30, 2024
@SergioEstevao SergioEstevao modified the milestones: 7.64 ❄️, 7.65 May 16, 2024
@SergioEstevao SergioEstevao marked this pull request as ready for review May 17, 2024 11:39
@SergioEstevao SergioEstevao requested a review from a team as a code owner May 17, 2024 11:39
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team May 17, 2024 11:39
@SergioEstevao SergioEstevao merged commit 0089319 into trunk May 20, 2024
4 checks passed
@SergioEstevao SergioEstevao deleted the fix_1072_scroll_indicator_insets branch May 20, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Scroll indicator behind player
2 participants