Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimagine Sharing: Add newSharing feature flag #1643

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Reimagine Sharing: Add newSharing feature flag #1643

wants to merge 2 commits into from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Apr 23, 2024 •
edited

Adds a newSharing feature flag.

To test

  • Check that newSharing appears in "Beta Features" and is disabled by default

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added this to the 7.63 milestone Apr 23, 2024
@bjtitus bjtitus requested a review from a team as a code owner April 23, 2024 22:02
@bjtitus bjtitus requested review from leandroalonso and removed request for a team April 23, 2024 22:02
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 23, 2024 •
edited

1 Warning
⚠️ This PR is assigned to the milestone 7.64. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus modified the milestones: 7.63 ❄️, 7.64 May 1, 2024
@bjtitus
Merge branch 'trunk' into bjtitus/sharing/feature-flag
cccfba7 
# Conflicts:
#	Modules/Utils/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift
@bjtitus bjtitus force-pushed the bjtitus/sharing/feature-flag branch from 116eb35 to cccfba7 Compare May 13, 2024 22:15
@bjtitus
Copy link
Contributor Author

bjtitus commented May 13, 2024

@leandroalonso This should be ready for review now that 7.63 is all fixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroalonso leandroalonso Awaiting requested review from leandroalonso leandroalonso is a code owner automatically assigned from Automattic/pocket-casts-ios

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reimagine Sharing
Projects
None yet
Milestone
7.64
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjtitus @dangermattic