[Tooling] Run Danger & SwiftLint on the Linter Agent #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
tooling
iangmaia
force-pushed
the
iangmaia/linter-agent
branch
from
759c0ff
to
06a3120
Compare
iangmaia
force-pushed
the
iangmaia/linter-agent
branch
from
870b0b7
to
a5b0437
Compare
iangmaia
force-pushed
the
iangmaia/linter-agent
branch
from
780746e
to
a5b0437
Compare
SergioEstevao
approved these changes
Apr 26, 2024
iangmaia
force-pushed
the
iangmaia/linter-agent
branch
from
5dd6b28
to
c6a4d0a
Compare
iangmaia
force-pushed
the
iangmaia/linter-agent
branch
from
8066172
to
5e63227
Compare
|
@iangmaia could you please wait before merging that? We'll need to make some changes on tl;dr: we had to revert the app version to a previous tag due to some performance issues. |
… the build in such cases
iangmaia
force-pushed
the
iangmaia/linter-agent
branch
from
a846741
to
3c9d461
Compare
mokagio
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new Linter Agent on Buildkite to run the Danger and SwiftLint jobs.
Because Danger will now run on Buildkite, this PR uses a new GitHub Actions workflow (see Automattic/dangermattic#64 for more details) to retry the Buildkite jobs when the PR state (such as the milestone and labels) changes.