Settings Sync: Default Values #1578
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
bjtitus
force-pushed
the
bjtitus/settings-sync/default-values
branch
from
d1403cc
to
2daecc5
Compare
| @@ -130,7 +130,8 @@ platform :ios do | |||
| desc 'Run the unit tests' | |||
| lane :test do | |||
| run_tests( | |||
| scheme: SCHEME | |||
| scheme: SCHEME, | |||
| xcargs: "-skipPackagePluginValidation" | |||
There was a problem hiding this comment.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
| @@ -408,6 +409,7 @@ platform :ios do | |||
| include_bitcode: false, | |||
| include_symbols: true, | |||
| clean: true, | |||
| xcargs: "-skipPackagePluginValidation", | |||
There was a problem hiding this comment.
| 🚫 | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
bjtitus
force-pushed
the
bjtitus/settings-sync/default-values
branch
from
2daecc5
to
18279d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default values for
PodcastSettingsandAppSettingsusing MetaCodable to ensure Decoding error don't cause data to be lost.To test
Checklist
CHANGELOG.mdif necessary.