Fix vertical video hiding title and controls

[mrpolanco]

Fixes #1034

Vertical video height does not obey bounds and overlays the title and podcast description/is clipped by the Now Playing heading.

To test

Downloaded two videos locally to test, one in landscape mode, and the other with a vertical aspect ratio (the latter the same as referenced in the original report):

Referenced vertical aspect video: https://en1.y2mate.is/w0p4c/watch?v=AQOm1WCV-g4

Test landscape aspect video: https://en1.y2mate.is/w0p3b/watch?v=C0DPdy98e4c

Once the videos were downloaded locally, they were dragged to the Photos app in each simulator, opened, and then shared with the Pocket Casts application:

Once added, videos can be accessed by clicking on the Profile tab, and Files:

The current issue for vertical videos (it hides the title and the top is clipped by the Now Playing heading for vertical videos). Landscape aspect videos do not present these issues:

Issue fix tested on various devices, including landscape video:

iPhone SE 3rd Gen:

iPad 10th Gen - The issue was also present, both in portrait and landscape orientations:

Before fix:

After fix:

Checklist

• ✅ I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  Rich: Nothing is needed, as it falls under general bug fixes.

• ✅ I have considered adding unit tests for my changes.
  Rich: Unit tests not deemed necessary.

• ✅ I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.
  Rich: Requesting updates to the spreadsheet, if any are needed.

[leandroalonso]

@mrpolanco thanks for working on this fix and for the detailed review instructions!

I found two issues while reviewing:

Constraints warning

After your changes, there are constraint warnings shown in the console for portrait videos:

2023-09-06 10:54:16.217999-0300 podcasts[4722:40251] [LayoutConstraints] Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want. 
	Try this: 
		(1) look at each constraint and try to figure out which you don't expect; 
		(2) find the code that added the unwanted constraint or constraints and fix it. 
(
    "<NSLayoutConstraint:0x6000011199f0 podcasts.VideoPlayerView:0x1176e8590.height == 354   (active)>",
    "<NSLayoutConstraint:0x600001289630 podcasts.VideoPlayerView:0x1176e8590.height == 330   (active)>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x6000011199f0 podcasts.VideoPlayerView:0x1176e8590.height == 354   (active)>

Basically we need just one place setting this constraint, otherwise the system gets confused as to which it should respect.

Video on iPad is small

Using the video you shared on a big iPad (Pro 12.9") the video is quite small:

Before	After

I think the best approach here would be to fill the available space with the video. Wdyt?

[leandroalonso]

This change is not needed for this fix. Probably the system changed and you committed by mistake.

[leandroalonso]

Same as above.

[leandroalonso]

Same as above.