Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Scroll indicator behind player #1072

Closed
BKrnk1337 opened this issue Aug 27, 2023 · 1 comment · Fixed by #1674
Closed

Bug: Scroll indicator behind player #1072

BKrnk1337 opened this issue Aug 27, 2023 · 1 comment · Fixed by #1674

Comments

@BKrnk1337
Copy link

When scrolling down in the episodes list of an podcast the scroll indicator disappears behind the player.

image
@rviljoen
Copy link
Contributor

I think the problem lies here:

pocket-casts-ios/podcasts/AddCustomViewController.swift

Lines 251 to 255 in da0e130

private func setupScrollViewOffset() {
let existingInset = scrollView.contentInset
scrollView.contentInset = UIEdgeInsets(top: existingInset.top, left: existingInset.left, bottom: existingInset.bottom + Constants.Values.miniPlayerOffset, right: existingInset.right)
}

When setting up the content inset, we should do the same for the vertical scroll bar, i.e.:

scrollView.verticalScrollIndicatorInsets = UIEdgeInsets(top: existingInset.top, left: existingInset.left, bottom: existingInset.bottom + Constants.Values.miniPlayerOffset, right: existingInset.right)

Also needs to be updated here:

pocket-casts-ios/podcasts/PodcastViewController.swift

Lines 338 to 339 in da0e130

let multiSelectFooterOffset: CGFloat = isMultiSelectEnabled ? 80 : 0
episodesTable.contentInset = UIEdgeInsets(top: navBarHeight(window: window), left: 0, bottom: Constants.Values.miniPlayerOffset + multiSelectFooterOffset, right: 0)

@rviljoen rviljoen mentioned this issue Nov 2, 2023
Closed
3 tasks
@rviljoen rviljoen mentioned this issue Apr 27, 2024
Merged
3 tasks
@SergioEstevao SergioEstevao mentioned this issue Apr 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rviljoen @BKrnk1337