Add NCC trickery #487
Open
Add NCC trickery #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiesshop
requested changes
May 17, 2024
| @@ -68,59 +173,156 @@ public function cmd_blocks_decode( array $pos_args, array $assoc_args ): void { | |||
| 'post_content' => $content, | |||
| ] | |||
| ); | |||
| WP_CLI::log( sprintf( 'Decoded blocks in %s', get_permalink( $post->ID ) ) ); | |||
| $this->logger->log( $logfile, sprintf( 'Decoded blocks in ID %d %s', $post->ID, get_permalink( $post->ID ) ), Logger::SUCCESS ); | |||
There was a problem hiding this comment.
To prevent false positives, I think we should change this to $updated = wp_update_post(...); if ( $updated) { $this->logger->log(...); And only increment $decoded_posts_counter if $updated === true
There was a problem hiding this comment.
Thanks! I've updated both places.
| wp_update_post( | ||
| [ | ||
| 'ID' => $post->ID, | ||
| 'post_content' => $content, | ||
| ] | ||
| ); | ||
| WP_CLI::log( sprintf( 'Encoded blocks in %s', get_permalink( $post->ID ) ) ); | ||
| $this->logger->log( $logfile, sprintf( 'Encoded blocks in post ID %d %s', $post->ID, get_permalink( $post->ID ) ), Logger::SUCCESS ); |
There was a problem hiding this comment.
Similar to comment from above, it'd be good to only display this information, if in fact we can confirm that wp_update_post was truly successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for args in the block encode/decode commands:
There is a new command that "nudges" posts to be picked up by the NCC - it just inserts a line break at the top of posts that start with
<!--that would otherwise not get picked up by the NCC.How to test
wp newspack-content-migrator transform-blocks-encode --num-items=50. The output will tell you next steps. It's also logged to file.wp newspack-content-migrator transform-blocks-nudge --num-items=30 --post-types=post,page