-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/newsletter reply to setting validation #37357
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Since you're asking for a review from Zap, maybe you meant to use the "Needs Team Review" label instead of "Needs Review"? "Needs Review" is meant to request an additional review from Crew, when you'd like an additional gut check that your team cannot provide. If you'd like this PR to be reviewed by Crew (or probably by your team :) ), could you add some testing instructions to make that easier? Thanks! |
@jeherve feels like these labels would be clearer:
|
@simison Yes, this has come up a few times in the past couple of years. I would agree. It makes more sense now that we no longer require approvals from the Approvers group. Last we talked about it was here: |
605501b
to
896f0cd
Compare
Proposed changes:
This improves the way that we validate reply_to by using the new method.
The new method was not yet shipped and the comment type is only supported by .com simple sites for now.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Go to /wp-admin/admin.php?page=jetpack#/newsletter
And save the Reply to setting.
Notice it saves as expected.