Nav: Highlight plugins menu in redesigned menus

[dsas]

Fixes https://github.com/Automattic/dotcom-forge/issues/6940

Proposed changes:

In Calypso the Plugins menu item always points to /plugins/:site
In wp-admin the Plugins menu always points to plugins.php

Plugins.php will include a button directing people to the WPCom
marketplace, and if necessary will also prompt them to upgrade.

This change ensures that the Plugins menu is always correctly
highlighted in the menu when on a Plugins page.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

0. Apply patch using the commands in the comment
1. Switch to an untangled simple site using a non-superuser account.
2. Press Plugins in the menu
3. You should arrive at /wp-admin/plugins.php and see a splash screen. The Plugins menu should be highlighted.
4. Click on the "Browse plugins" button
5. You should see the plugins marketplace screen. The Plugins menu should be highlighted
6. Repeat on an untangled atomic site, the same should occur.
7. Repeat on tangled sites, they should act as they do in production.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/plugins-menu branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/plugins-menu
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[dsas]

Oh, I just realised this is probably only working on the marketplace due to the bug with Scheduled Updates 😫

Oh, I see now, I probably need to update the wpcom Calypso menu too to override the parent class which always hardcodes plugin.php for classic view

[mmtr]

I'm seeing a duplicated "Scheduled Updates" menu now on Atomic sites:

Before	After

[mmtr]

When visiting the Plugins Marketplace of an Atomic site, the menu changes as following:

Before (prod)	After (this PR)

Would it be possible to keep the "Installed Plugins" and "Add New Plugins" menus so users can go back to wp-admin?

[mmtr]

In Calypso the Plugins menu item always points to /plugins/:site
In wp-admin the Plugins menu always points to plugins.php

Plugins.php will include a button directing people to the WPCom
marketplace, and if necessary will also prompt them to upgrade.

Now that I further think on this, I wonder if the menu for Simple sites should point to /wp-admin/plugins.php at all.

/wp-admin/plugins.php is completely useless and it just redirects users to /plugins/:site or to upgrade. Considering that /plugins/:site already has an upgrade nudge, cannot we just make the Plugins menu to always redirect to /plugins/:site for Simple sites?

[dsas]

Now that I further think on this, I wonder if the menu for Simple sites should point to /wp-admin/plugins.php at all.

I wondered exactly the same thing @mmtr on p1714466658219309/1714411102.901939-slack-C04DZ8M0GHW I think at this point we need to p2 and get clarity from design.

[mmtr]

For anyone following this PR, we're discussing next steps in pfsHM7-YW-p2