-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Add account connection confirmation UI #37295
Conversation
This is currently a proof of concept where we get the available external services and render a connect button, which in turn triggers the authentication flow for each service. To test it, the site must be sandboxed with D146389-code applied.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Social plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
1c9d7bd
to
e6cc39f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming along nicely. Thanks for picking it up.
...ackages/publicize-components/src/components/add-connection-modal/confirmation-form/index.tsx
Outdated
Show resolved
Hide resolved
...ackages/publicize-components/src/components/add-connection-modal/confirmation-form/index.tsx
Outdated
Show resolved
Hide resolved
...ackages/publicize-components/src/components/add-connection-modal/confirmation-form/index.tsx
Show resolved
Hide resolved
...ackages/publicize-components/src/components/add-connection-modal/confirmation-form/index.tsx
Show resolved
Hide resolved
projects/js-packages/publicize-components/src/components/add-connection-modal/services-list.tsx
Show resolved
Hide resolved
projects/js-packages/publicize-components/src/components/add-connection-modal/index.tsx
Show resolved
Hide resolved
...ackages/publicize-components/src/components/add-connection-modal/confirmation-form/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks!
I have one issue, where when connecting, my previously connected accounts doesn't appear as connected
CleanShot.2024-05-14.at.15.46.18.png.mp4
After the request is finished it connects it, so I have the connection connected 2 times:
After that it works fine. It might be related to the fact that the connections were connected in Calypso before, but that's not ideal if we cannot get around that 🤔
This only happened once, after it was working well.
Did you sandbox D148435-code as mentioned in the instructions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now!
This builds on #37196 and adds a component to allow the user to confirm the account to be connected.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Please ensure to sandbox D148435-code to ensure Facebook pages are correctly marked as already connected.
Screen.Recording.2024-05-10.at.8.59.28.PM.mov