Add/tracks events for my jetpack product card action button dropdown #37292

CodeyGuyDylan · 2024-05-08T19:34:27Z

Proposed changes:

Add tracks events for My Jetpack product card action button dropdown
Fixed issue where chevron was not closing dropdown, only opening it
Fixed typo with with the connection banner

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Slack: p1714642553738749-slack-C06CVN9QVFY

Does this pull request change what data or activity we track or use?

Yes, we are adding tracks for the dropdown button for backups

Testing instructions:

Checkout this branch via the Jetpack Beta plugin or your local dev environment
Purchase VaultPress Backup for your site
Wait for a backup to happen and then add an image or audio file or something to trigger an activity action that can be undone
Go to /wp-admin/admin.php?page=my-jetpack and confirm you can see the dropdown (Screenshot doesn't have activity log item because I was forcing it visible in testing)
Open the dropdown and confirm you see the following event in Tracks Vigilante
Try closing it with the Chevron or by clicking outside of it and confirm you see a tracks event like this
Select the items inside of it and confirm you see tracks events for this
Make sure opening the dropdown and closing it works as expected
If you want, connect your site from the banner and make sure Connected is spelled correctly

github-actions · 2024-05-08T19:35:28Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/tracks-events-for-my-jetpack-product-card-action-button-dropdown branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/tracks-events-for-my-jetpack-product-card-action-button-dropdown

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-05-08T19:35:36Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

IanRamosC

The code looks mostly fine, but I couldn't get the events to be recorded.
I also left a minor comment about the naming convention we use for Tracks events

IanRamosC · 2024-05-11T02:14:16Z

projects/packages/my-jetpack/_inc/components/product-card/action-button.jsx

@@ -202,9 +205,17 @@ const ActionButton = ( {
 		[ additionalActions, getStatusAction, hasAdditionalActions ]
 	);

+	const recordDropdownStateChange = useCallback( () => {
+		recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggled', {


For consistency, we tend to use the verb at the end in infinitive form. See more about that here

IanRamosC · 2024-05-11T02:14:41Z

projects/packages/my-jetpack/_inc/components/product-card/action-button.jsx

@@ -235,6 +250,11 @@ const ActionButton = ( {
 					const onDropdownMenuItemClick = () => {
 						setCurrentAction( allActions[ index ] );
 						setIsDropdownOpen( false );
+
+						recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_clicked', {


Same here

Suggested change

recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_clicked', {

recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_click', {

IanRamosC · 2024-05-11T02:15:26Z

projects/packages/my-jetpack/_inc/components/product-card/action-button.jsx

@@ -202,9 +205,17 @@ const ActionButton = ( {
 		[ additionalActions, getStatusAction, hasAdditionalActions ]
 	);

+	const recordDropdownStateChange = useCallback( () => {
+		recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggled', {


Suggested change

recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggled', {

recordEvent( 'jetpack_myjetpack_product_card_dropdown_toggle', {

IanRamosC

Code looks good and tests well.

github-actions bot added the [Package] My Jetpack label May 8, 2024

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label May 8, 2024

CodeyGuyDylan force-pushed the add/tracks-events-for-my-jetpack-product-card-action-button-dropdown branch from 30281ed to fd525e8 Compare May 8, 2024 19:39

IanRamosC requested changes May 11, 2024

View reviewed changes

CodeyGuyDylan added 3 commits May 14, 2024 09:39

Add tracks events for My Jetpack product card action button dropdown

2f38332

changelog

e418578

Update tracks names to adhear to standards

893ce22

CodeyGuyDylan force-pushed the add/tracks-events-for-my-jetpack-product-card-action-button-dropdown branch from b6bf1bc to 893ce22 Compare May 14, 2024 15:39

IanRamosC assigned CodeyGuyDylan May 14, 2024

IanRamosC previously approved these changes May 14, 2024

View reviewed changes

IanRamosC added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels May 14, 2024

Fixup project versions

8f43aeb

CodeyGuyDylan dismissed IanRamosC’s stale review via 8f43aeb May 14, 2024 16:59

IanRamosC self-requested a review May 14, 2024 17:04

IanRamosC approved these changes May 14, 2024

View reviewed changes

CodeyGuyDylan merged commit 4064692 into trunk May 14, 2024
70 checks passed

CodeyGuyDylan deleted the add/tracks-events-for-my-jetpack-product-card-action-button-dropdown branch May 14, 2024 17:15

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add/tracks events for my jetpack product card action button dropdown #37292

Add/tracks events for my jetpack product card action button dropdown #37292

CodeyGuyDylan commented May 8, 2024

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

IanRamosC left a comment

IanRamosC May 11, 2024

IanRamosC May 11, 2024

IanRamosC May 11, 2024

IanRamosC left a comment

	recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_clicked', {
	recordEvent( 'jetpack_myjetpack_product_card_dropdown_action_click', {

Add/tracks events for my jetpack product card action button dropdown #37292

Add/tracks events for my jetpack product card action button dropdown #37292

Conversation

CodeyGuyDylan commented May 8, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented May 8, 2024 • edited

github-actions bot commented May 8, 2024 • edited

IanRamosC left a comment

Choose a reason for hiding this comment

IanRamosC May 11, 2024

Choose a reason for hiding this comment

IanRamosC May 11, 2024

Choose a reason for hiding this comment

IanRamosC May 11, 2024

Choose a reason for hiding this comment

IanRamosC left a comment

Choose a reason for hiding this comment

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited