Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCRE 8.30 -> 8.45 #316

Open
wants to merge 7 commits into
base: v1.1
Choose a base branch
from
Open

PCRE 8.30 -> 8.45 #316

wants to merge 7 commits into from

Conversation

sswwaagg
Copy link
Contributor

@sswwaagg sswwaagg commented Jan 5, 2023

updated to the last ever supported PCRE1 version, which fixes some internal and other regex related bugs and introduces UTF32 string support.

the resulting binary is larger though

@miketestz
Copy link

miketestz commented Feb 21, 2023

RegexMatch function for binary data does not function normally when PCRE is updated.

1
When I updated it,

2
Original

3
Script Code Partial

This script is part of Ahk2exe(AHKType.ahk).

The updated pcre returns PCRE_ERROR_BADUTF8,16,32 after running the pcret_exec function.

@Lexikos
Copy link
Collaborator

Lexikos commented Jun 10, 2023

We would need a patch for the issue @miketestz described before this can be merged. I don't plan to work on it myself at this stage.

@Lexikos
Copy link
Collaborator

Lexikos commented Mar 23, 2024

I'm not planning to update v1.1, but left this open in case of updating PCRE for v2. Unfortunately, the AutoHotkey changes for callouts were not preserved, and callouts like (?C:functionname) are not working. I do not know whether PCRE itself has made changes to the callout encoding compared to the previous PCRE version.

Also, the update introduces build warnings on x64.

I intend to look into updating the alpha branch to PCRE2 instead, but last time I looked into it, I could not find any information about changes to the API or differences in behaviour, aside from some issues caused by the transition between PCRE versions for PHP. It still isn't a priority for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants