Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fields to be filtered by id only in Get-JiraField (mainly for use in Set-JiraIssue) #476

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PiotrBaran1010
Copy link

Description

This is a fix for a situation I have encountered, where someone created a field with a duplicated name, which then caused Set-JiraIssue to be unable to set a value for previously existing field, since Get-JiraField returned two values, while only one of the fields were present in the issue I was updating, resulting in "Field 'xxx' cannot be set. It is not on the appropriate screen, or unknown." error. Added switches to Get-JiraField and Set-JiraIssue that allow user to call the fields directly by their id's, which allows to bypass this issue.

Motivation and Context

Fixes issue with updating field value in an issue, in a case when multiple fields of the same name exist, but are not present in this issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@PiotrBaran1010 PiotrBaran1010 requested review from a team as code owners May 19, 2023 10:04
Copy link
Member

@lipkau lipkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not review this PR earlier.

Now that the CI is working again, it shows the tests that are failing.

Please update your PR with the missing parameter documentation and write tests for the newly added behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants