Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-JiraRemoteLink Allows Adding Remote Links #424

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bormm
Copy link

@bormm bormm commented Sep 2, 2020

Picket the "patch zip" from #375 and created a extended version and a pull request.

Description

This adds the Add-JiraRemoteLink function from #375 in a massive extended version. Due the original one only allowed url and txt attribute, I used the format defined by Get-JiraRemoteLink. For that I also created a ConvertFrom-JiraLink as counterpart to the existing ConvertTo-JiraLink.

Motivation and Context

I do not understand why there was a format change of the incoming JSON, as done in Get-JiraRemoteLink, in this case useful anyway but that's an other discussion and I wanted the change to be compatible to the existing stuff as possible.

As the previous discussed original, this only allows adding additional remote links, which is also reflected in the naming of the function. For that the function verifies that there is no Id or RestUrl in the object, because that would only make sense for updating existing remote links and could confuse the user of this function.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

 - extended Add-JiraRemoteLink, so it can accept the result of for example Get-JiraRemoteLink if id and Rest is removed before
@bormm bormm requested review from a team as code owners September 2, 2020 14:35
@bormm
Copy link
Author

bormm commented Sep 2, 2020

There are no tests and documentation currently, I am not sure if I am able to add them in my very limited work time for this project.
So I would be happy if someone could extend my pull request with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant