Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixer: use ardour widgets instead of gtk natives for plugin list #874

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jean-emmanuel
Copy link
Contributor

The native dropdown and the "clear" button felt somewhat out of place, this brings some more unity in that regard.

The second commit is an experiment that might be worth considering: having all plugins available in the list with the search option could be a time saver, don't you think ?

@x42
Copy link
Member

x42 commented Mar 14, 2024

I have not forgotten about this.

Yet I'm not sure if "ALL plugins is a good idea". Some users (notably on windows) have a few thousand, and the sidebar also shows presets (some synths have hundreds). Keep in mind that GTK::Treeview performance degrades significantly with many entries (> 1k).

If you want to find a specific plugin from all available one the dynamically built context-menu or plugin-selector are a lot more ergonomic.

@jean-emmanuel
Copy link
Contributor Author

I understand, I have a few hundred plugins and selecting the option for the first time already takes a short yet noticeable additional time. If the rest is fine do you want me to drop the last commit ?

@x42
Copy link
Member

x42 commented May 3, 2024

I grabbed the first commit 8.6-86 4e44f44 but not the "All Plugins".

I tested the "ALL" plugins and it's not just slow (took 4-5 sec), but also somewhat useless to scroll though and find the right one.

It would be nice to have a "search all plugins" options.
One idea: by default the list is empty, and only when a user typed 3 chars in search, plugins are listed.
Not great, not terrible. Maybe you have a better idea?

@jean-emmanuel
Copy link
Contributor Author

jean-emmanuel commented May 3, 2024

Hey, that's good news thank you ! I like the idea (indeed the ALL option seemed to only make sense with a few chars typed in the search field), I'll try to fiddle with it
as soon as I have some time to play with the code again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants