Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Automation control point operations #744

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

RFC: Automation control point operations #744

wants to merge 6 commits into from

Commits on Sep 18, 2023

  1. Larger and transparent automation control points 

    The control points were very small and hard to spot, especially when
painted on top of waveforms.

Also, the snap size for automation lines were bigger than for the
control points at the end, making it hard to click the control points.

Fixed by making the control points twice as big - that seems to match
the size of the automation line snapping.

To avoid control points showing up as too big solid blocks blocking too
much, we stop making them filled. The bigger outline is more visible
than the old solid block.
    @kiilerix
    kiilerix committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1156828 View commit details
    Browse the repository at this point in the history

  2. Reorder ControlPointDrag::motion to prepare for the next change 

    A pure refactoring.
    @kiilerix
    kiilerix committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    63ee95e View commit details
    Browse the repository at this point in the history

  3. When dragging automation points, only drag horizontally or vertically 

    The most common drag operation on an automation point is with the intent
of either moving it in time or in value. That was very hard to achieve
when both dimensions were free.

Slightly similar to "Ignore Y-axis when adding new automation-points",
we thus "snap" the move to either being horizontal or vertical.

In the rare occation where we want to move in both dimensions at once,
we can still and fully intuitively do that with 2 drag operations.
    @kiilerix
    kiilerix committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    0d99285 View commit details
    Browse the repository at this point in the history

  4. Refactor to let Editor::can_remove_control_point take a ControlPoint … 

    …reference

Avoid retrieving control_point from Item both in
Editor::remove_control_point and in Editor::can_remove_control_point .

remove_control_point is called from Editor::button_release_handler, and
is very view-ish, so it is fine that it takes an Item.

can_remove_control_point is slightly more low level and model-ish
(almost so much that it could live in AudioRegionGainLine), so it kind
of makes sense that it works on the ControlPoint.

There is no extra code. The retrieval of ControlPoint moves from
can_remove_control_point to Editor::popup_control_point_context_menu .

This refactoring will make it easier to implement deletion of multiple
selected points.
    @kiilerix
    kiilerix committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    80d6aa1 View commit details
    Browse the repository at this point in the history

  5. Allow removing multiple control points 

    It was surprising that removing on multiple selected control points only
removed one of them.

This allows selecting multiple points by dragging a box or
Ctrl-clicking, then removing all from the context menu of one of the
points.

Some more trivial implementations of this suffered from problems when
deletion of control points in the model also invalidated the iterator
over selected control points.
    @kiilerix
    kiilerix committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    dda27cd View commit details
    Browse the repository at this point in the history

  6. PoC: Implement += -= *= /= for control point editing 

    For example, if editing a control point at 7 dB and entering "+= 3"
in the input field instead of "7", it will set the control pointto 10
dB.

This is especially useful when editing multiple automation points at
once.
    @kiilerix
    kiilerix committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4c8e2b7 View commit details
    Browse the repository at this point in the history