bounced region name issue

[yonideshi]

Bounced regions were named after track. Previous version of Ardour added "bounce" to the name. It seems that it was overlooked. Sometimes it is difficult to find bounced region when there are tens or hundred of regions on the list. Methods new_audio_source_path and new_midi_source_path correctly enumerate and "legalize" files paths. Probably this suffix could be added a region name only.

[pauldavisthefirst]

This commit will break for multichannel tracks, because you've removed the channel number from the name. I like the general idea. Care to fix that particular problem?

[yonideshi]

1. "base_name" was unused variable, so channel info was not considered in this part of code
2. "new_audio_source_path" method calls "legalize_for_path" internally and then rebuilds file name correctly using channel number information
3. Summarizing: "new_audio_source_path" method previously took "/path/file_name" rebuild it with channel info and took care of collisions. With this commit it will take "/path/file_name-bounce" and will follow as before.

Thanks.

[luzpaz]

Is this ticket still relevant ?

[pauldavisthefirst]

hard to say. It's not an issue I've seen raised over the lat 6 years ....

[luzpaz]

@yonideshi are you planning to follow-up ?

[x42]

Since Ardour 6.3 (specifically f564c92 and 80a7d32) there is a prompt for new region-names to mitigate this issue.
Rather than unconditionally adding a "bounce" suffix the user is prompted to specify a name.