This repository has been archived by the owner on May 21, 2024. It is now read-only.
Add customizable keybind for closing modals #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Kong/insomnia#4877 There are a couple other places that had 'Escape' hardcoded for some kind of keydown event, but it seems mostly harmless - AFAIK this was the biggest painful hardcoded shortcut.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #128
Original upstream issue Kong/insomnia#4877
Adds a customizable shortcut for closing modal windows, which was previously hardcoded to
Escape. This allows users with Vim keybindings to rebind it to something else, particularly for Environment editor, since Escape is used to exit insert mode with Vim keybindings.There are a couple other places that had 'Escape' hardcoded for some kind of keydown event, but it seems mostly harmless — AFAIK this was the biggest painful hardcoded shortcut.