Quick Reblog: Add dialog height option for Quick Tags Integration. #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,6 +357,7 @@ export const main = async function () { | |||
| $(document.body).on('mouseenter', reblogButtonSelector, showPopupOnHover); | |||
|
|
|||
| if (quickTagsIntegration) { | |||
| setQuickTagsSize(Number.parseInt(quickTagsIntegrationSize)); | |||
There was a problem hiding this comment.
I would probably move this parseInt call into the rest of the parsing logic, since it seems related.
There was a problem hiding this comment.
Suggested change
| setQuickTagsSize(Number.parseInt(quickTagsIntegrationSize)); | |
| setQuickTagsSize(quickTagsIntegrationSize); |
AprilSylph
requested changes
Feb 18, 2023
Comment on lines
+278
to
+281
| const parseQuickTagsSize = (size) => { | ||
| if (!Number.isInteger(size)) { | ||
| return 4; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const parseQuickTagsSize = (size) => { | |
| if (!Number.isInteger(size)) { | |
| return 4; | |
| } | |
| const parseQuickTagsSize = (sizeString) => { | |
| const size = Number.parseInt(sizeString); | |
| if (Number.isNaN(size)) return 4; |
| @@ -340,6 +357,7 @@ export const main = async function () { | |||
| $(document.body).on('mouseenter', reblogButtonSelector, showPopupOnHover); | |||
|
|
|||
| if (quickTagsIntegration) { | |||
| setQuickTagsSize(Number.parseInt(quickTagsIntegrationSize)); | |||
There was a problem hiding this comment.
Suggested change
| setQuickTagsSize(Number.parseInt(quickTagsIntegrationSize)); | |
| setQuickTagsSize(quickTagsIntegrationSize); |
|
This is lovely, but would it be possible to also provide an "expand to fit" option? Say, if the config variable is set to |
|
That's pretty much equivalent to removing the maximum value from this PR and the user setting an extremely high number, which may be simpler. |
|
Would that also shrink the list if `length(tagBundles) < N`? Expand to fit, but no more. If so, sure.
|
|
Yep! That's what it does currently. |
|
Oh, I have had so many bundles for so long I don't recall ever seeing that. Then ignore me being silly, if there's no limit and I can just set it to 813 or whatever that's great.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an option in Quick Reblog's preferences to increase or decrease the height of the Quick Tags Integration dialog.
This addresses the issue raised in #867.
It parses the the preference from Quick Reblog and sets it as a CSS variable in
quickTagsListcomponent. This makes it available on every subsequent render of the Quick Reblog popup dialog without having to check every single time.The variable changes the height of the dialog from 1 to 20 units, each unit being the height of the button which is the same height as each tag element.
Default (4):
Size 10:
Size 1:
Testing steps
To test, go to the Quick Reblog preferences and set a height different than the default of 4. The change should be reflected immediately.