Quick Reblog: Add keyboard navigation #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| event.stopPropagation(); | ||
|
|
||
| if (enableKeyNav) { | ||
| if (event.key === 'Enter' && event.ctrlKey) { |
There was a problem hiding this comment.
For consistency on Macs, this should probably include metaKey as an alternative!
AprilSylph
requested changes
Feb 19, 2023
| event.stopPropagation(); | ||
|
|
||
| if (enableKeyNav) { | ||
| if (event.key === 'Enter' && event.ctrlKey) { |
There was a problem hiding this comment.
Suggested change
| if (event.key === 'Enter' && event.ctrlKey) { | |
| if (event.key === 'Enter' && (event.ctrlKey || event.metaKey)) { |
Comment on lines
+74
to
+78
| }, | ||
| "enableKeyNav": { | ||
| "type": "checkbox", | ||
| "label": "Enable keyboard navigation", | ||
| "default": true |
There was a problem hiding this comment.
I don't see the need to make this a preference. Let's just build it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #899.
While the popup's comment input or tag input are focused, this adds Ctrl + Enter to reblog and Escape to close the popup.
Demonstration
Ctrl + Enter to reblog in comment input field:
Ctrl + Enter to reblog in tag input field:
Escape to close the popup while either comment or tag field are focused:
Testing steps
Check the option in Quick Reblog's preferences and use Ctrl + Enter while either tag or input field are focused.