Enhancement: PostBlock blocks instantly. #898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alleycatboy
force-pushed
the
enhancement_postblock_block_instantly
branch
from
384e6af
to
713c54b
Compare
|
Now using CSS selectors instead of directly adding/removing classes as suggested here. |
alleycatboy
force-pushed
the
enhancement_postblock_block_instantly
branch
2 times, most recently
from
0de226f
to
384e6af
Compare
marcustyphoon
requested changes
Feb 21, 2023
| async (postElement) => { | ||
| const { rebloggedRootId } = await timelineObject(postElement); | ||
| const rootID = rebloggedRootId || postElement.dataset.id; | ||
| postElement.dataset.targetRootId = rootID; |
There was a problem hiding this comment.
These need to be removed in clean()!
| const styleElement = buildStyle(); | ||
| const buildCss = () => | ||
| `:is(${blockedPostRootIDs | ||
| .map((rootId) => `[data-target-root-id="${rootId}"]`) |
There was a problem hiding this comment.
Here we should target the article elements within the post elements, not the post elements themselves, to avoid breaking J/K scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #894 reported by @marcustyphoon by using the same caching as Seen Posts to block posts during soft navigation.
Testing steps
Enable PostBlock script and use as normal.