Refactor: use replaceChildren
pattern to create lists
#1445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As noted in #677 (comment), there are a number of places where we could use
replaceChildren
to update a list's contents in the DOM all in one go, rather than emptying it, (often) waiting asynchronously for a preference fetch, then adding the desired elements in one-by-one.The meaningful behavior change resulting from this is that if the code throws or the preference fetch stalls, the old elements are left in place rather than the list becoming blank, which may be a more confusing failure mode.
Testing steps