Tag Tracking+: Fix search dropdown mode #1325
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the "improved search typeahead" change (is this out to everyone?), the search dropdown doesn't contain every tracked tag, and clicking a button in the dropdown opens a new modal interface with all of one's tracked tags.
This honestly makes Tag Tracking+'s search-only mode feel kind of pointless, at least to me? Not sure if we should simply remove it (either the functionality in its entirety or just the mode selector). Would like to hear opinions on that.
Anyway, this makes the mode at least work. My CSS is a little odd? Not sure if it could be improved.
Testing steps