Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have, like, zero opinion about what any of this is called, what format it uses, whatever.
The notable choice we have here is whether to:
pageModifications
, which has slightly less performance impact but will fail on elements that Tumblr updates theclassList
of (like when you switch dashboard tabs and the tab elements become highlighted/unhighlightedattributeFilter: ['class']
and just querySelector the whole damn document, which is technically slower (though I run this as a userscript 100% of the time; the performance hit is not noticable)attributeFilter: ['class']
and parse themutationRecord
(fancy~)Testing steps