Pre release changes 0.5.0 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubnowicki
force-pushed
the
pre-release-changes-0.5.0
branch
from
dfde755
to
2148a80
Compare
federiva
approved these changes
Jan 16, 2024
| choices[[.x]], choices_value[[.x]], | ||
| ~ shiny::div(class = "item", `data-value` = .y, .x) | ||
| ) | ||
| if (is.null(names(choices))) { |
There was a problem hiding this comment.
Style comment:
There are places in which we are using explicitly namespaced functions like here purrr::map and other places in which we don't. Why not using @importFrom purrr map map2 etc... in here?
If there is a reason to do so then it's fine, if not, then maybe we should start to consolidate the style.
If you think we should consolidate it then I can create an issue for it
There was a problem hiding this comment.
We definitely should consolidate - if you could create an issue that would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.