Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oriol.sprite fun #320

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Oriol.sprite fun #320

wants to merge 16 commits into from

Commits on Nov 13, 2020

  1. Feat: New functions addsvg_sprite and rmsvg_sprite to modify sprite maps 

    Both functions require use of xml2 package.
    @osenan
    osenan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    3b62437 View commit details
    Browse the repository at this point in the history

  2. Update documentation for sprite map functions

    @osenan
    osenan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    4b2c05e View commit details
    Browse the repository at this point in the history

  3. Update DESCRIPTION

    @osenan
    osenan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    536c288 View commit details
    Browse the repository at this point in the history

  4. Update NAMESPACE

    @osenan
    osenan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    dc2bab2 View commit details
    Browse the repository at this point in the history

  5. fix: Reduce size of svg examples

    @osenan
    osenan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    2efa17b View commit details
    Browse the repository at this point in the history

  6. Update last examples in documentation

    @osenan
    osenan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    3697232 View commit details
    Browse the repository at this point in the history

  7. include unit tests for addsvg_sprite and rmsvg_sprite

    @osenan
    osenan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    b4af868 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Fix: Typo in rmsvg_sprite documentation

    @osenan
    osenan committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    11f21e5 View commit details
    Browse the repository at this point in the history

  2. Fix: 

    * Change function and variable names to fit with coding style:
	- addsvg_sprite for add_svg_sprite
	- rmsvg_sprite for remove_svg_sprite
	- idExists for id_exists

* Simplify code in id_exists return statement, easier to read and mantain

* Update tests and documentation according to changes in functions
    @osenan
    osenan committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    267129a View commit details
    Browse the repository at this point in the history

  3. Fix: Add message when id not found

    @osenan
    osenan committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    d33882d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. first example app version

    @osenan
    osenan committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    8dbe91f View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Feat: add new examples to add_svg_sprite and remove_svg_sprite

    @osenan
    osenan committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    cd2becc View commit details
    Browse the repository at this point in the history

  2. update NAMESPACE

    @osenan
    osenan committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    bf91b4f View commit details
    Browse the repository at this point in the history

  3. update documentation

    @osenan
    osenan committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    65ec290 View commit details
    Browse the repository at this point in the history

  4. add name as contributor to DESCRIPTION

    @osenan
    osenan committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5bcd517 View commit details
    Browse the repository at this point in the history

  5. include svg files for add_svg_sprite examples

    @osenan
    osenan committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    cc966a1 View commit details
    Browse the repository at this point in the history