New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
box_usage_linter #571
box_usage_linter #571
Conversation
can lint functions not imported by box
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
===========================================
+ Coverage 34.11% 59.26% +25.14%
===========================================
Files 10 17 +7
Lines 554 896 +342
===========================================
+ Hits 189 531 +342
Misses 365 365 ☔ View full report in Codecov by Sentry. |
@jakubnowicki I added
to the test cases where it makes sense. All tests just worked as expected. When you have time, please take a look. It was a surprise for me. |
|
||
expect_true(TRUE) | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests for lambda functions
(function (x) x + 1)(1)
{function (x,y) x+y}(2, 3)
(\(x) x+1)(1)
Changes
Packages
box::use(shiny[no_func])
box::use(package[function])
box::use(package)
box::use(package[...])
Local functions
Box modules
TODO
Packages
Local functions
handle S4Will not do.setMethod()
attachmentbox
andS4
do not play well together.Box modules
How to test