Handle LazySeq key value in RingResponseAdapter header add #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ring produces a "Set-Cookie" header with a LazySeq as value that cannot directly be cast into a CharSequence and causes an error. Thus the key type must first be checked and the first item taken before creating a header. Currently only the first value is taken and is obviously broken if the sequence contains more than item. IMO this can be handled later in case this situation arises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message description on the rationale of this change. There is unfortunately not a unit test as I was not able to figure out how to add one to the current unit tests.
I also fixed a minor error in the contributing document.