Add more parity with iOS (breaking change), refactor module, fix theming #32
Conversation
|
@AppWerft This PR is ready for review. cc @chmiiller since you heavily use this module as well I think. |
hansemannn
changed the title
| } else { | ||
| Log.d(LCAT, "no clientID found!"); | ||
| Log.e(LCAT, "No clientID found!"); | ||
| return; | ||
| } | ||
|
|
||
| GoogleSignInOptions gso = new GoogleSignInOptions.Builder( | ||
| GoogleSignInOptions.DEFAULT_SIGN_IN) | ||
| .requestIdToken(serverClientId).requestProfile().requestEmail() |
There was a problem hiding this comment.
In order to get more parity with iOS, we should add here .requestServerAuthCode(serverClientId) because currently it returns null whereas iOS returns right.
There was a problem hiding this comment.
Does that have side-issues? If we don't request the id-token, will it still include the idToken? EDIT: See this for details. We should probably not change that?
There was a problem hiding this comment.
mmm I see, I'm using it to authorize my server as stated https://developers.google.com/identity/sign-in/android/offline-access. I'm not an expert on this, just my use case requires to have both in order to get the same response than in iOS module
|
Used this PR in my app. Thank you @hansemannn ! |
Hey there,
this pull attempts to add more parity with iOS, especially for the returned profile inside the login event (commit 1). Also, this pull adds some meta files so this module can easily be developed inside Android Studio. Let me know if you want to take those changes as well or if I should remove them again.
Cheers!
Also closes #30 and #9. I'd even argue that all open issues should be closed. Most of them (#28, #14, #29, #18, #17) are questions and should be moved to StackObverflow or TiSlack.
Download: ti.googlesignin-android-4.0.0.zip