Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "boolean" type to storage #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

needhamgary
Copy link

This allows typescript users to write storage: false in the options.

Changes

Status

  • [ x ] These changes have been tested and formatted properly.
  • This PR includes only documentation changes (JSDoc, README or typings), no code change.
  • This PR introduces some breaking changes.

This allows typescript users to write `storage: false` in the options.
@Nico105
Copy link
Collaborator

Nico105 commented Jun 28, 2023

If I'm not mistaken it's not necessary to set it to false anymore.
The code example with that included should be removed.
So you can just not use it / leave it undefined, no?

@needhamgary
Copy link
Author

When I don't use it, it defaults to "./giveaways.json" and undefined will also fault out in typescript because it's not a string

@Nico105
Copy link
Collaborator

Nico105 commented Jul 1, 2023

But so are you using a custom db?
Because if you are extending the getAllGiveaways function then the "default" shouldn't matter to you.

So I don't really understand what you are trying to achieve/what your logic is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants