New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support horizontal overflow #82
base: main
Are you sure you want to change the base?
Conversation
This is useful for `textarea` elements that contain code, but with line lengths greater than the `textarea`'s width
hey @chrisdrackett , is original behaviour preserved after ur change? Did u test it doesnt break any other assumptions? Would like to incorporate your fix, but with such changes we need to be cautious. Do u use ur fork in ur projects and everything is working like expected? |
@Andarist I missed your note somehow, sorry about that. We are using this fork in our project without any issues. I did test this with our use of the package, but I'm not sure if I'm running the same tests that others are! |
@chrisdrackett Could u showcase ur use case on smth like codesandbox.io? I could then experiment with ur use case and some other ones - unfortunately this package has no tests 😭 so I'm really cautious about introducing changes, especially related to those particular properties lists as they seem fragile. |
I'm a few years behind, but I came up with a similar problem. demo: simply copy & paste the url to the demo page. I see that the code has changed a bit since, so we can't just merge the PR right away. I'm curious whether solving this issue is still of interest? OBS. It's 100% coincidence that the original author and I have a similar avatar |
From the given screenshot im not sure what the problem is. Could u describe it? |
I'd expect the textarea to resize in accordance with word wrapping as well, so having a single long line of text wouldn't create any vertical scroll bars. |
Well, you don't have a horizontal overflow there - you get a vertical scrollbar. And this is expected as this particular textarea has react-textarea-autosize/example/index.tsx Line 11 in 58c9807
|
You're right. Sorry I didn't check the source for other props. For some reason I do keep encountering vertical sidebars, especially when I work with long urls. That's how I reached here in the first place. |
I don't have an example at this time as I ended up just moving to |
Any chance for this PR to still be merged? I'm using this lib for a custom code input and the calculated height is incorrect when I set |
Actually, I don't think this will work as the PR adds |
This is useful for
textarea
elements that contain code, but with line lengths greater than thetextarea
's width