Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lambda-git #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ikedam
Copy link
Contributor

@ikedam ikedam commented Sep 17, 2018

Though it looks expected to have opt/git-2.4.3.tar expanded when deploying, it results following error:

Serverless: Operation failed!

  Serverless Error ---------------------------------------

  An error occurred: ProcessbundleLambdaFunction - Unzipped size must be smaller than 262144000 bytes (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: xxxxxxxxxxxxxxxxxxxxxxxxxxx).

This request uses lambda-git instead.

* Uploading expanded git-2.4.3.tar causes failure for exceeding upload size limitations.
if (gitExpand && fs.existsSync(GitPath)) {
// Use the existing one as it takes much time to expand git everytime.
return execGitCmdImpl(cmd, cwd, env);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.js often fails for timeouts ( > 40s) without this.

@AnalogJ
Copy link
Owner

AnalogJ commented Feb 23, 2019

LGTM.
I think it would be valuable to add a test suite for gitmask. Would you be interested in taking on some of that work @ikedam ?

@ikedam
Copy link
Contributor Author

ikedam commented Feb 24, 2019

I agree adding tests improves our development.
I’ll take a look on test features of the serverless framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants