refactor(ui): perks section and tickets page #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted `BaristaPerksSection` to a `StatelessWidget` as it did not utilise any stateful features. - Transitioned `BaristaPerksSection` and `UserRoleIndicator` to accept a `String` instead of `Role`. This prevents duplicate conversion/formatting from `Role` to `String` in these widgets. - Made `tickets_page.dart` more state safe by removing UserState cast and taking into account cases where UserState is not UserWithData. - Extracted ticket contents of `TicketsPage` to a private widget to maintain readablity. - Fixed the incorrect usage of `context.read` inside of the build method of `TicketsPage`. The refactor improves overall code maintainability and aligns with best practices for widgets that do not require internal state management.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
=======================================
Coverage 68.76% 68.76%
=======================================
Files 133 133
Lines 1697 1697
=======================================
Hits 1167 1167
Misses 530 530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaristaPerksSectionto aStatelessWidgetas it did not utilise any stateful features.BaristaPerksSectionandUserRoleIndicatorto accept aStringinstead ofRole. This prevents duplicate conversion/formatting fromRoletoStringin these widgets.tickets_page.dartmore state safe by removing UserState cast and taking into account cases where UserState is not UserWithData.TicketsPageto a private widget to maintain readablity.context.readinside of the build method ofTicketsPage.The refactor improves overall code maintainability and aligns with best practices for widgets that do not require internal state management.