Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Test) Remove Firebase from the app #550

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

(Test) Remove Firebase from the app #550

wants to merge 4 commits into from

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Nov 16, 2023

In an attempt to speed up iOS build speeds, Firebase has been completely removed from the project.

Relevant issue flutter/flutter#37582

In an attempt to speed up iOS build speeds, Firebase has been completely removed from the project.
@marfavi marfavi changed the title WIP Remove Firebase from the app (Test) Remove Firebase from the app Nov 16, 2023
@marfavi
Copy link
Member Author

marfavi commented Nov 16, 2023

The test results are in:

iOS build on this branch took 6m59s compared to 18m27s on other branches. This is a reduction of over 11 minutes(!)

@marfavi marfavi added ios Only impacts iOS or needs iOS-specific work discuss dependencies Pull requests that update a dependency file labels Nov 16, 2023
@marfavi marfavi marked this pull request as draft November 16, 2023 21:42
@AnalogIO AnalogIO deleted a comment Nov 16, 2023
@AnalogIO AnalogIO deleted a comment from codecov bot Nov 16, 2023
}
"project_info": {
"project_number": "897975858437",
"project_id": "analogio-47cf0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason my code editor decided to change indentation of this file. Rest assured the only real change here is removing the firebase url field.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db0df6d) 72.85% compared to head (ec5f6c2) 71.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   72.85%   71.88%   -0.98%     
==========================================
  Files         130      129       -1     
  Lines        1573     1515      -58     
==========================================
- Hits         1146     1089      -57     
+ Misses        427      426       -1     
Flag Coverage Δ
unittests 71.88% <100.00%> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

i broke something on the android side. hopefully this will fix it

will attempt to re-enable R8 in the next commit
let's see how this goes
@TTA777
Copy link
Member

TTA777 commented Nov 20, 2023

Would be great if we could reduce pipeline time, but not sure if this is the right way to go. Have we tried the fix from firebase/flutterfire#2751 ? Even if that doesn't fix it, wouldn't we still want the information that firebase is able to provide us, otherwise we are in the dark about issues happening in the app. If the aforementioned fix doesn't work, I'm all for looking at alternatives to firebase, perhaps something relying on openTelemetry, if dart has support for that by now 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file discuss ios Only impacts iOS or needs iOS-specific work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants