-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Test) Remove Firebase from the app #550
base: main
Are you sure you want to change the base?
Conversation
In an attempt to speed up iOS build speeds, Firebase has been completely removed from the project.
} | ||
"project_info": { | ||
"project_number": "897975858437", | ||
"project_id": "analogio-47cf0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason my code editor decided to change indentation of this file. Rest assured the only real change here is removing the firebase url field.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 72.85% 71.88% -0.98%
==========================================
Files 130 129 -1
Lines 1573 1515 -58
==========================================
- Hits 1146 1089 -57
+ Misses 427 426 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
i broke something on the android side. hopefully this will fix it will attempt to re-enable R8 in the next commit
let's see how this goes
Would be great if we could reduce pipeline time, but not sure if this is the right way to go. Have we tried the fix from firebase/flutterfire#2751 ? Even if that doesn't fix it, wouldn't we still want the information that firebase is able to provide us, otherwise we are in the dark about issues happening in the app. If the aforementioned fix doesn't work, I'm all for looking at alternatives to firebase, perhaps something relying on openTelemetry, if dart has support for that by now 🤔 |
In an attempt to speed up iOS build speeds, Firebase has been completely removed from the project.
Relevant issue flutter/flutter#37582