Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): E-Mail capitalization issue #1820

Closed
wants to merge 2 commits into from

Conversation

DollyXSoul
Copy link

@DollyXSoul DollyXSoul commented Mar 20, 2024

Fixes #1740

This issue affects email in three places where user needs to enter the email - during registration ,login and forgot-password page.
To fix that we convert the email to lowercase before processing or sending to db.

-> During the user registration , the email entered by user is converted to lowercase and then stored in db.

->Similarly , in forgot-password , so again as we do a check in db if given email exists or not, so again make given user email to lowercase.

-> And in login user can enter email or username(already in lowercase) so if we convert user-input to lowercase it won't affect login using username.

@AmruthPillai
Copy link
Owner

@DollyXSoul Wouldn't there be some need to case-insensitivize the backend auth checks as well?

@DollyXSoul
Copy link
Author

@AmruthPillai Yes you are right I forgot about that. Should I just convert email to lowercase on backend as well , or you have a better suggestion to do this ??

@AmruthPillai
Copy link
Owner

I tried running this locally, and ran into some issues when trying to login with an existing account that had capitalization already stored in the database. For now, I'm going to close the PR as I feel this is one place in the app where it might need some regression tests.

But thank you very much for your efforts. It is very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] E-Mail Login is dependent on capitalization
2 participants